Change in vdsm[master]: Remove local mount point if storage server connection fails
shuming at linux.vnet.ibm.com
shuming at linux.vnet.ibm.com
Fri May 11 00:11:50 UTC 2012
Shu Ming has posted comments on this change.
Change subject: Remove local mount point if storage server connection fails
......................................................................
Patch Set 1:
It is a policy issue here:
1) Should we allow to mount the local existing local directory with files under it? if we don't allow this mount operation, we can just change the exception handling as:
except OSError as e:
if (e.errno != errno.EEXIST) || (not_empty(local_directory)):
raise
2) if we do allow it. we have a flag to test if rmdir should be done in the other exception handling.
--
To view, visit http://gerrit.ovirt.org/4298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7aa1a47b7fa3577e83daa82fbad17fdc2ebd51f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list