Change in vdsm[master]: Implement Popen without forking back to python

smizrahi at redhat.com smizrahi at redhat.com
Thu May 10 20:01:14 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Implement Popen without forking back to python
......................................................................


Patch Set 12: (3 inline comments)

....................................................
File vdsm/betterPopen/__init__.py
Line 36:     def __init__(self, args, close_fds=False, cwd=None, env=None):
Yea, I don't support that, only args is supported. you are thinking about the "executable" arg from the original. Like many other arguemts I removed in sake of brevity.

Line 48:     def _execute_child(self, args, executable, preexec_fn, close_fds,
I have looked at the original code. In any case it doesn't matter as I implement the _execute_child interface.

Future python versions might change the name of the method and we will have to change as well, it's better in my opinion then re-implementing everything.

This method is meant to be overriden and it is internally by the various Popen implementations.

....................................................
File vdsm/betterPopen/Makefile.am
Line 27: 
The entire build process requires the same machine
RHEL v FEDORA

Also we don't support any other arch

--
To view, visit http://gerrit.ovirt.org/3944
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief4ae42eb57551d7f5893bf562da451a9c98f219
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list