Change in vdsm[master]: Add support for redir devices

oourfali at redhat.com oourfali at redhat.com
Thu May 10 18:12:32 UTC 2012


Oved Ourfali has posted comments on this change.

Change subject: Add support for redir devices
......................................................................


Patch Set 2:

Hey,

Regardless the results of the upstream discussion on the address part, in the engine we pass all the attributes besides type and device, as a dictionary called specParams.
So, in this case the model in the controllers, master in the controllers and the bus in the redir devices, must be passed in this dictionary.

so it would look like:
devices='{type:controller,device:usb,specParams{model:ich9-uhci1,master:{startport:0}},address:{type:pci,domain:0x0000,bus:0x00,slot:0x04,function:0x0,multifunction:on}}'

same for the redir device:
devices='{type:redir,device:spicevmc,specParams{bus:usb},address:{type:usb,bus:0,port:2}}'

Doesn't seem like a major change.
Sorry that my comment comes only now. I just now did some testing and saw that this is indeed the situation.

Adding Eli to the reviewers to make sure I'm right.

--
To view, visit http://gerrit.ovirt.org/4133
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia91922a0f34cb4b32efa2c6397d13fe59aec04e7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>


More information about the vdsm-patches mailing list