Change in vdsm[master]: BZ#797526 Wait pool connection before recovery

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Thu May 10 06:15:39 UTC 2012


Royce Lv has posted comments on this change.

Change subject: BZ#797526 Wait pool connection before recovery
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 1301:         self.preparePaths(devices[vm.DISK_DEVICES])
Because of prepared path in the recovery period, in libvirtvm.py,
 there are a lot of functions count on the _volumesPrepared label to avoid queries
 from storage during recovery process,
 this breaks them,
eg:I got this error when testing the patch:
Thread-55::ERROR::2012-05-10 13:32:04,328::utils::399::vm.Vm::(collect) 
vmId=`f7c1b02f-b304-4e68-8565-3659b1214cb3`::Stats function failed: 
<AdvancedStatsFunction _sampleDiskLatency at 0x23e8f10>

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 395,in collect
    statsFunction()
  File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 272, in __call__
    retValue = self._function(*args, **kwargs)
  File "/usr/share/vdsm/libvirtvm.py", line 163, in _sampleDiskLatency
    stats = _blockstatsParses(out)
  File "/usr/share/vdsm/libvirtvm.py", line 150, in _blockstatsParses
    'flush_op':devStats['flush_operations'],
KeyError: 'flush_operations'

....................................................
File vdsm/storage/hsm.py
Line 317:             poolPath = os.path.join(self.storage_repository, spUUID)
since poolPath is not checked, this line should be clean,or build will fail

--
To view, visit http://gerrit.ovirt.org/4283
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I418ce9641d1cdb7f7202fd8c08e7c027d1f6d325
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list