Change in vdsm[master]: Fix usage message for vdsm-tool

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue May 8 14:40:17 UTC 2012


Mark Wu has posted comments on this change.

Change subject: Fix usage message for vdsm-tool
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm-tool/vdsm-tool
Line 96:     print "Usage: %s [options] <action> [arguments]\n" % sys.argv[0]
Ryan,
I don't understand why you said we need specify both the command name and its module name. From the code of vdsm-tool, it collects all exposed function by scanning all *.py files in 'vdsm.tool' directory and puts into one dict:  tool_command.

So, we needn't specify module name to invoke a command. If the same command name appears in different module, it could cause conflict. In that case, specifying a module in the command line of vdsm-tool could help. Is  the "module" name is needed in design but not implemented?

Thanks

--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list