Change in vdsm[master]: Modify scripts in vdsm_cli/ for PEP8 compliance
shaohef at linux.vnet.ibm.com
shaohef at linux.vnet.ibm.com
Tue May 8 05:59:58 UTC 2012
ShaoHe Feng has posted comments on this change.
Change subject: Modify scripts in vdsm_cli/ for PEP8 compliance
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
you should modify the style as I mentioned in the comment.
....................................................
File vdsm_cli/vdsClient.py
Line 1309: ancestor, successor, postZero)
the two line arguments should be aligned.
here is an example. http://www.python.org/dev/peps/pep-0008/
....................................................
File vdsm_cli/vdscli.py.in
Line 108: cert_file=CERTFILE, ca_certs=CACERT)
the style.
these two line arguments should aligned.
--
To view, visit http://gerrit.ovirt.org/4106
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I449fb43d215bb96cd12478de11b126d79d1faf41
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list