Change in vdsm[master]: vdsClient.py: Allow specifying nested dicts for devices when...

danken at redhat.com danken at redhat.com
Mon May 7 08:30:15 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsClient.py: Allow specifying nested dicts for devices when creating a vm
......................................................................


vdsClient.py: Allow specifying nested dicts for devices when creating a vm

With this patch one can do things like:
vdsClient 0 create /dev/null \
    vmId=00000001-0002-0003-0004-000000000006 vmName=F14-x86_64 memSize=512 \
    macAddr=52:54:00:7a:b4:7e nicModel=virtio bridge=test display=qxl \
    devices='{type:disk,device:disk,path:/home/virt-images/f14-i386.qcow2.img,propagateErrors:off,iface:ide,index:0,readonly:False,format:cow}' \
    devices='{type:video,device:qxl,specParams:{vram:65536}}'

Which allows testing vdsm with the new devices create params syntax from the
cmdline with vdsClient.

Change-Id: Ibe4eb528684c1d2053cb9574d8f63bbbf0a03c23
Signed-off-by: Hans de Goede <hdegoede at redhat.com>
---
M vdsm_cli/vdsClient.py
1 file changed, 43 insertions(+), 1 deletion(-)

Approvals:
  Hans De Goede: Verified
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/4094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe4eb528684c1d2053cb9574d8f63bbbf0a03c23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list