Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes
ilvovsky at redhat.com
ilvovsky at redhat.com
Mon May 7 08:02:48 UTC 2012
Igor Lvovsky has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(3 inline comments)
Only minor comments
....................................................
Commit Message
Line 12: In this way we circunvent the races product of working with many
s/circunvent/circumvent
....................................................
File vdsm/storage/blockSD.py
Line 143: log.warning("Ingnoring Volume %s that lacks minimal tag set"
s/Ingnoring/Ignoring
Line 164: not vName.startswith(blockVolume.image.REMOVED_IMAGE_PREFIX) \
I still hate this blockVolume.image.REMOVED_IMAGE_PREFIX
--
To view, visit http://gerrit.ovirt.org/3462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eccf5ca100bd354aa09208ca60bb112fb697063
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list