Change in vdsm[master]: Added gluster cli support in supervdsm.

barumuga at redhat.com barumuga at redhat.com
Sun May 6 15:27:37 UTC 2012


Bala.FA has posted comments on this change.

Change subject: Added gluster cli support in supervdsm.
......................................................................


Patch Set 10: (5 inline comments)

....................................................
File configure.ac
Line 131: AC_PATH_PROG([GLUSTER_CLI_PATH], [gluster], [/usr/sbin/gluster])
Done

....................................................
File vdsm/gluster/gluster_exception.py
Line 363: if __name__ == "__main__":
Could you tell me the test name/file?

....................................................
File vdsm/gluster/__init__.py.in
Line 24:     sys.path.append('@VDSMDIR@')
We were using storage.mount and there was no path to it.  It was achieved by this.  Its not useful now, but if needed in future whats your thought on this?

....................................................
File vdsm.spec.in
Line 491: %{_datadir}/%{vdsm_name}/vdsm_exception.py*
Done

Line 780: %{_datadir}/%{vdsm_name}/gluster/gluster_exception.py*
Done

--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list