Change in vdsm[master]: libvirtvm.py: Refactor device xml generation

danken at redhat.com danken at redhat.com
Sun May 6 08:25:07 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: libvirtvm.py: Refactor device xml generation
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

thanks a lot for this cleanup! two minor comments, though.

....................................................
File vdsm/libvirtvm.py
Line 827:     def createXmlElem(self, elemType, type, attributes = []):
style: no space around this equal op.

Line 1030:             type = 'block'
"type" is a python builtin, please find another name.

--
To view, visit http://gerrit.ovirt.org/4132
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e1c5a2d0998af38fa80d53975b0e528b9257a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list