Change in vdsm[master]: Added Gluster file system management support.
barumuga at redhat.com
barumuga at redhat.com
Sat May 5 02:42:24 UTC 2012
Bala.FA has posted comments on this change.
Change subject: Added Gluster file system management support.
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File vdsm/gluster/gluster_api.py
Line 27: def verbMethod(func):
Done
Line 31: wrapper.verbMethod = 'yes'
Problem here is, getattr(self.svdsmProxy , ANY, None) returns non-None value always. However getattr(func , ANY, None) == True will work. I feel defined string value is much more reliable. Need to know your thoughts here.
--
To view, visit http://gerrit.ovirt.org/2808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd51bec292991f7abdcacf3ba747c9662f660f51
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
More information about the vdsm-patches
mailing list