Change in vdsm[master]: vm payload: add file injection to vm

danken at redhat.com danken at redhat.com
Fri May 4 13:56:55 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vm payload: add file injection to vm
......................................................................


Patch Set 31: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/mkimage.py
Line 77:             m.mount(mntOpts='loop')
Saggi noted that if m.mount() is moved above the "try"
you can simplify the "finally" and have there an unconditional umount().

Line 90:         dirname = tempfile.mkdtemp()
good. I'm fine with using /tmp, certainly for vm payload.

--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list