Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...
ilvovsky at redhat.com
ilvovsky at redhat.com
Thu May 3 14:57:00 UTC 2012
Igor Lvovsky has posted comments on this change.
Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Do we need to add USB Redirected devices as well?
In separate patch of course.
....................................................
File vdsm/libvirtvm.py
Line 861: ctrl.setAttribute('model', self.model)
As I can see from libvirt definition, you will need to add 'index' attribute as well:
http://libvirt.org/formatdomain.html#elementsControllers
<devices>
<controller type='usb' index='0' model='ich9-ehci1'>
<address type='pci' domain='0' bus='0' slot='4' function='7'/>
</controller>
<controller type='usb' index='0' model='ich9-uhci1'>
<master startport='0'/>
<address type='pci' domain='0' bus='0' slot='4' function='0' multifunction='on'/>
</controller>
...
</devices>
Line 871: ctrl.appendChild(master)
Is it necessary to handle 'master' as dictionary?
Can it be something else except single
<master startport='0'/> ?
--
To view, visit http://gerrit.ovirt.org/4095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4fd6bed73cfa67fd6b29d3c352aebc7c25cff5f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list