Change in vdsm[master]: Fix usage message for vdsm-tool

Ryan Harper ryanh at us.ibm.com
Wed May 2 12:18:27 UTC 2012


Ryan Harper has posted comments on this change.

Change subject: Fix usage message for vdsm-tool
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

You should separate out your pep8 fixes from the code changes.  This allows the maintainers to cherry pick out just that change.

....................................................
File vdsm-tool/vdsm-tool
Line 96:     print "Usage: %s [options] <action> [arguments]\n" % sys.argv[0]
module is correct here.  vdsm-tool will load up additional modules (.py files) and in each of those modules, we can choose to expose certain functions.  When you want to invoke one of the exposed functions, you need to specify both the function name (this is the <action>) and in which module this action occurs.

--
To view, visit http://gerrit.ovirt.org/4065
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5382130f9003da983c88a708aa9ee2abe072f3d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list