Change in vdsm[master]: configNetwork: additional skipLibvirt

danken at redhat.com danken at redhat.com
Wed May 2 11:42:01 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: configNetwork: additional skipLibvirt
......................................................................


Patch Set 2: I would prefer that you didn't submit this

I cannot say that I'm happy with this approach. skipLibvirt was a hasty hack, introduced for the bootstrapping use case. it should NOT become so prevalent in the code.

addNetwork and delNetwork must be capable of handling bridges that were added outside of Vdsm.

What is exactly the scenario trigerring the error (yes, I know networking is terribly broken atm)

--
To view, visit http://gerrit.ovirt.org/3941
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list