Change in vdsm[master]: Added register-to-engine command line tool.

danken at redhat.com danken at redhat.com
Wed May 2 08:27:46 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added register-to-engine command line tool.
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm_reg/register-to-engine.py
Line 139:     if not deployUtil.setVdsConf("vdc_host_name=%s" % newVdcHostName,
there were several (wrong?) reasons to write our own function for this (maintaining order and comments I believe). I'd be happy to replace deployUtil.setVdsConf, but that's outside of the scope of this patch.

--
To view, visit http://gerrit.ovirt.org/3113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list