Change in vdsm[master]: [WIP] MOM Integration

abaron at redhat.com abaron at redhat.com
Tue May 1 22:26:35 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: [WIP] MOM Integration
......................................................................


Patch Set 6: (7 inline comments)

Note I have not reviewed the patch, just replying to Doron's comment so I cannot rate the patch yet.

....................................................
File vdsm/clientIF.py
Line 92: 
Mom is a policy engine, it doesn't mandate a specific policy so if the policy changes in the future, we need not change the API (or the code at all) just the policy passed to mom, so I'm not sure what you're suggesting.

....................................................
File vdsm/Makefile.am
Line 40:         vdsMOM.py \
Again, please keep alphabetical sort.

Line 134: 	mom.conf
and again

Line 156: 		install-data-libvirtpass \
would be nice to sort this list

Line 174: 		uninstall-data-libvirtpass \
same here

....................................................
File vdsm.spec.in
Line 493: %{_sysconfdir}/%{vdsm_name}/mom.policy
please sort alphabetically

Line 578: %{_datadir}/%{vdsm_name}/vdsMOM.py*
same here

--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list