Change in vdsm[master]: BZ#788640 - Template relink refactored.

abaron at redhat.com abaron at redhat.com
Tue May 1 08:17:38 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#788640 - Template relink refactored.
......................................................................


Patch Set 7: I would prefer that you didn't submit this

(5 inline comments)

....................................................
Commit Message
Line 7: BZ#788640 - Template relink refactored.
why?

....................................................
File vdsm/storage/image.py
Line 380:         Relink all hardlinks of the template 'volUUID' in all VMs based on it
This function assumes that dom is backup dom
and that template image is used by other volumes

Line 389:         if len(tImgs) < 2:
test is redundant

Line 394:         tSelfImage = tImgs[0]
s/tSelfImage/templateImage/

Line 401:             oop.getProcessPool(destDom.sdUUID).os.link(os.path.join(self.repoPath, destDom.sdUUID, sd.DOMAIN_IMAGES, tSelfImage, volUUID), tLink)
why not reverse and do this atomically?

--
To view, visit http://gerrit.ovirt.org/3467
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I087fc777e202088615c82be1a88fcde15b846628
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list