Change in vdsm[master]: [REVIEW ONLY] Added Gluster file system management support.
barumuga at redhat.com
barumuga at redhat.com
Sat Mar 31 10:09:30 UTC 2012
Bala.FA has posted comments on this change.
Change subject: [REVIEW ONLY] Added Gluster file system management support.
......................................................................
Patch Set 2: (6 inline comments)
....................................................
File vdsm/BindingXMLRPC.py
Line 898: except ge.GlusterException, e:
I agree with you. currently only gluster verbs error handling is done through exception. I will send separate new patch for basic vdsm exception which will be inherited by gluster exception.
....................................................
File vdsm/gluster/gluster_cli.py
Line 48: if line.upper() == "NO VOLUMES PRESENT":
Localization is not yet supported by gluster. However gluster cli will give info in xml soon ie these parsing will be thrown out.
Line 82: volumeOptions[tokens[0].strip()] = tokens[1].strip()
gluster cli will give output in xml soon. So these parsing will go away. Till then I don't sure about this change requirement.
Line 93: volumeInfo["replicaCount"] = m.groups()[1]
Done
Line 100: volumeInfo["stripeCount"] = m.groups()[1]
Done
....................................................
File vdsm/gluster/gluster_exception.py
Line 42: self.err = err if err else []
Done
--
To view, visit http://gerrit.ovirt.org/2808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd51bec292991f7abdcacf3ba747c9662f660f51
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
More information about the vdsm-patches
mailing list