Change in vdsm[master]: Added VDSM interface for the virt-alignment-scan tool from l...

tomic80 at gmail.com tomic80 at gmail.com
Wed Mar 28 12:43:01 UTC 2012


Saša Tomić has posted comments on this change.

Change subject: Added VDSM interface for the virt-alignment-scan tool from libguestfs
......................................................................


Patch Set 4: (7 inline comments)

....................................................
File tests/alignmentScan_test.py
Line 41: class ScanImageBadPathTestCase(unittest.TestCase):
Done

Line 45: def mkimage(imagepath):
Done

Line 46:     cmd = "/bin/dd if=/dev/zero".split() + ["of=%s" % imagepath] + "bs=4K count=1K".split()
That's quite reasonable actually. Thanks!

Line 51:         img = tempfile.NamedTemporaryFile()
Done

Line 56:         cmd.append(img.name)
Unfortunately, --unit argument is not an option on fedora16 that I'm running.

....................................................
File vdsm/alignmentScan.py
Line 29: def runScanArgs(args):
Done

Line 51:     ScanOutput = namedtuple('ScanOutput', ['partition_name', 'partition_start_bytes', 'partition_alignment', 'alignment_scan_result'])
seems reasonable.

--
To view, visit http://gerrit.ovirt.org/2916
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2c146a0fa3101317720f2e9c373e0d21b5cfdf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saša Tomić <tomic80 at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Saša Tomić <tomic80 at gmail.com>


More information about the vdsm-patches mailing list