Change in vdsm[master]: Fix the new lv_name field for the new lvm lib.

smizrahi at redhat.com smizrahi at redhat.com
Tue Mar 20 14:33:35 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Fix the new lv_name field for the new lvm lib.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

My patch fixes that and doesn't assume stupid things about how things are formatted is uses the canonical way that VDSM uses to get device guids. I'm annoyed as it is with all the weird formatting assumptions that lvmcache uses. Stop reimplementing logic, devicemapper.py and multipath.py are balanced for speed and correctness, use their abilities. Don't optimize more when you don't have to.

I don't want to start a stupid mine is bigger then yours war so I'd concede if I'm the only one that thinks that more shaky name mangling is NOT the solution.

--
To view, visit http://gerrit.ovirt.org/2952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988b72af48bc5024f410a0a4296d553d352c8440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list