Change in vdsm[master]: vm payload: add file injection to vm

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Mon Mar 19 09:21:43 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: vm payload: add file injection to vm
......................................................................


Patch Set 7: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/constants.py.in
Line 54: P_PAYLOAD_PREFIX = '/var/run/vdsm/payload/'
You said you wanted something more persistent between reboots so I think /var/run is a bad place. From the FHS 
(http://www.pathname.com/fhs/pub/fhs-2.3.html#VARRUNRUNTIMEVARIABLEDATA):

This directory contains system information data describing the system since it was booted. Files under this directory must be cleared (removed or truncated as appropriate) at the beginning of the boot process.

It sounds like you want to use /var/tmp (http://www.pathname.com/fhs/pub/fhs-2.3.html#VARTMPTEMPORARYFILESPRESERVEDBETWEE):

The /var/tmp directory is made available for programs that require temporary files or directories that are preserved between system reboots. Therefore, data stored in /var/tmp is more persistent than data in /tmp.

....................................................
File vdsm/mkimage.py
Line 95:     isopath = tempfile.NamedTemporaryFile(prefix=P_PAYLOAD_PREFIX, delete=False)
The documentation (http://docs.python.org/library/tempfile.html) clearly specifies a dir parameter.

--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list