Change in vdsm[master]: vds_bootstrap: add flags for installVirtualizationService an...

ilvovsky at redhat.com ilvovsky at redhat.com
Thu Mar 15 15:48:12 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: vds_bootstrap: add flags for installVirtualizationService and installGlusterService
......................................................................


Patch Set 5: Verified; Looks good to me, approved

(1 inline comment)

Verified by Haim

....................................................
File vds_bootstrap/vds_bootstrap_complete.py
Line 79:         logging.debug("installVirtualizationService = '%s', installGlusterService = '%s'"%(installVirtualizationService, installGlusterService))
I preferred spaces between '%s' and  lines < 80  .
But, it's a bootstrap and it's anyway very ugly

--
To view, visit http://gerrit.ovirt.org/2504
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I883a5c36ff72a7c59b3e6a8b33d06924a5781d20
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>


More information about the vdsm-patches mailing list