Change in vdsm[master]: [WIP: REVIEW ONLY] Added Gluster file system management supp...

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Wed Mar 14 18:08:48 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: [WIP: REVIEW ONLY] Added Gluster file system management support.
......................................................................


Patch Set 1: (6 inline comments)

Partial review

....................................................
File configure.ac
Line 181: 	vdsm/gluster/Makefile
I think this is supposed to be sorted.

....................................................
File vdsm/BindingXMLRPC.py
Line 38:     from gluster.gluster_binding import getGlusterMethods
I think you want absolute imports here, so vdsm.gluster.

Line 43:     import gluster.gluster_exception as ge
Same here about absolute imports

Line 898:         except ge.GlusterException, e:
This will throw a NameError if ge was not imported.

....................................................
File vdsm/gluster/gluster_api.py
Line 77:                                transportList))
How about:

 transport = ','.join(filter(None, (transportMap.get(x.upper()) for x in transportList)))

....................................................
File vdsm/gluster/gluster_exception.py
Line 299:             raise NameError, "Collision with RHEVM found: %s code %s: " \
How about oVirt here?

--
To view, visit http://gerrit.ovirt.org/2808
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd51bec292991f7abdcacf3ba747c9662f660f51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list