Change in vdsm[master]: BZ#800915 - no need to support list in removeVM command

abaron at redhat.com abaron at redhat.com
Tue Mar 13 15:55:42 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#800915 - no need to support list in removeVM command
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/API.py
Line 904:         return self._irs.removeVM(self._UUID, vmUUID, sdUUID)
No actually the old code didn't.  The join was introduced by Adam in his API.py and it broke backwards compatibility.
However, there is no reason to keep the plural in API.py, only in the xmlrpc bindings, so I agree that this should be changed here.

--
To view, visit http://gerrit.ovirt.org/2694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a0e5848ece1aa147f4508d4d16842bcdb30af0d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>


More information about the vdsm-patches mailing list