Change in vdsm[master]: Add function getNetworkList to API bridge

danken at redhat.com danken at redhat.com
Sun Mar 11 14:40:27 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Add function getNetworkList to API bridge
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

Again, I'd prefer to see how this new function is going to be used. Splitting networking out of getVdsCaps has its own sense, but your commit message is misleading - the REST binding could use the current function.

....................................................
File vdsm/API.py
Line 1209:         print "Networks:", networkList
print?

--
To view, visit http://gerrit.ovirt.org/2664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6689b31541fc98ff7a7951eedbb99270c60a0738
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lei Li <lilei at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list