Change in vdsm[master]: void check pool masterver not zero when connecting

agl at us.ibm.com agl at us.ibm.com
Thu Mar 8 13:36:41 UTC 2012


Adam Litke has posted comments on this change.

Change subject: void check pool masterver not zero when connecting
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

Just a couple of suggested fixes for you to make and you can resubmit it.

....................................................
File vdsm/storage/hsm.py
Line 839
You could have the same issue here as well (and several other places in this function).

Line 847:             if not hostID or not scsiKey or not msdUUID:    
1. You have some trailing whitespace here.
2. I don't think you can just remove the check here.  The better way to fix this is to stop relying on Python's boolean semantics for these checks:

if hostID is None or scsiKey is None or msdUUID is None:

This way you are actually checking for a missing parameter.

--
To view, visit http://gerrit.ovirt.org/2645
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb0f4618e78735d6ae5e25e81b9ea544540691c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>


More information about the vdsm-patches mailing list