Change in vdsm[master]: Backing VG's should be named as SD name. Renaming VG's is no...

danken at redhat.com danken at redhat.com
Wed Mar 7 13:33:59 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Backing VG's should be named as SD name. Renaming VG's is not supported.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

I have no idea why we had this code path in the past (maybe to utilize an existing, differently named VG?).

However this is never used by Engine, and it should not, as it may introduce a metadata-changing operation on HSM.

--
To view, visit http://gerrit.ovirt.org/2602
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ad2b24dbc7595ad52e04c3664d51f6d7f27036
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list