Change in vdsm[master]: DO NOT SUBMIT - wip - vds_bootstrap: add flags for installVi...

danken at redhat.com danken at redhat.com
Mon Mar 5 08:06:38 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: DO NOT SUBMIT - wip - vds_bootstrap: add flags for installVirtualizationService and installGlusterService
......................................................................


Patch Set 2: I would prefer that you didn't submit this

this is so very ugly (as the rest og the bootstrap code).

* consider replacing flags with a list of installed services (e.g. -s virt,gluster)

* rebase on my change 1931

* fix commit message

* keep lines shorter than 80 chars

* make sure we have a changed ovirt-engine version to conflict with, due to this api change.

--
To view, visit http://gerrit.ovirt.org/2504
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I883a5c36ff72a7c59b3e6a8b33d06924a5781d20
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>


More information about the vdsm-patches mailing list