Change in vdsm[master]: Implement storage server connection aliasing

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Thu Mar 1 16:19:51 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Implement storage server connection aliasing
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/storage/storageServer.py
Line 380: class IlligalAliasError(RuntimeError): pass
Illegal

I'd also prefer to see pass on a new line and an empty line between classes, but that might be my style

--
To view, visit http://gerrit.ovirt.org/1693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: shu ming <sming56 at gmail.com>


More information about the vdsm-patches mailing list