Change in vdsm[master]: Add a basic xmlrpc functional test

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Fri Jun 29 07:58:47 UTC 2012


Royce Lv has posted comments on this change.

Change subject: Add a basic xmlrpc functional test
......................................................................


Patch Set 1: Verified

(2 inline comments)

....................................................
File tests/functional/xmlrpcTests.py
Line 45:         self.assertIn(r['statsList'][0]['status'], ('Up', 'Powering up'))
I remember the "Running" status is also a valid up status for vm with guest agent

Line 59:         VMID = '66666666-ffff-4444-bbbb-333333333333'
Can I advice using str(uuid.uuid4())? ;)

--
To view, visit http://gerrit.ovirt.org/5788
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list