Change in vdsm[master]: Replace configure_sysctl with /etc/sysctl.d/vdsm.conf

danken at redhat.com danken at redhat.com
Thu Jun 28 11:35:04 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Replace configure_sysctl with /etc/sysctl.d/vdsm.conf
......................................................................


Patch Set 2: (4 inline comments)

Thanks a lot. I like the idea of not playing with global config files. Let's make the tinkering even less, and only during installation.

....................................................
File vdsm.spec.in
Line 534: %config(noreplace) %{_sysconfdir}/sysctl.d/vdsm.conf
libvirt does not put the .conf in the file name. let's do the same.

....................................................
File vdsm/vdsmd.init.in
Line 430: remove_sysctl()
I do not think you'd need to run this every time vdsm starts - it could be moved to  vdsm.spec, where it is to be run post-intallation, and only after upgrade from a version that played with /etc/sysctl.conf.

Line 433: 	# So remove them in /etc/sysctl.conf
please avoid tabs

Line 442:         sed -e "/vm.dirty_ratio/d" \
I think it is too brutal to remove anything outside VDSM_SYSCTL section.

--
To view, visit http://gerrit.ovirt.org/5763
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fcf28d63715ceb6e77d3b93cea4a55c192a777e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list