Change in vdsm[master]: Handle bond properly if connectivity check fail.

danken at redhat.com danken at redhat.com
Wed Jun 27 08:27:23 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Handle bond properly if connectivity check fail.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 1068:         # keep dict {network:explicitBond} to be able remove
explicitBond? or implicit? what did you mean?

Line 1073:         networksAdded = {}
I cannot say that I like the over-usage of of the same variable for two things.

True/False here tells nothing about the meaning of the value.
I'd prefer another list (or dictionary) of "netsWithNewBonds".

--
To view, visit http://gerrit.ovirt.org/5712
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bb04f6f3b8d5cdbfd9af8904570af071af6d4f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>


More information about the vdsm-patches mailing list