Change in vdsm[master]: Properly parse configurations in function "do_create" in vds...

danken at redhat.com danken at redhat.com
Wed Jun 27 07:54:32 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Properly parse configurations in function "do_create" in vdsClient
......................................................................


Properly parse configurations in function "do_create" in vdsClient

Before the patch:
1. The function "do_create" accepts a config file and a set of arguments.
For nested values, it only parses them from arguments but not from config
file. So all nested values in the config file will not be passed to vdsm,
causing some components and configs missing in the created VM.
2. When parsing nested values in arguments, it add the both the raw value
and parsed value into the result dictionary.

After the patch:
1. Properly parse nested values from both config file and arguments.
2. Do not add useless raw value into the result dictionary.

Patch Set 4:
Add unit test for function "do_create" to verify config file is parsed
the same way as command line parameters.

Patch Set 5:
Add hacks for importing vdscli.py and vdsClient.py in unit test.

Patch Set 6:
More readable name for contexManager function.

Change-Id: I0cd6801a6d4de3f51fc7d1e0f744bcb2c71d422f
Signed-off-by: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
---
M tests/Makefile.am
M tests/run_tests_local.sh.in
M tests/testrunner.py
A tests/vdsClientTests.py
M vdsm_cli/vdsClient.py
5 files changed, 149 insertions(+), 30 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Zhou Zheng Sheng: Verified


--
To view, visit http://gerrit.ovirt.org/5093
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0cd6801a6d4de3f51fc7d1e0f744bcb2c71d422f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list