Change in vdsm[master]: Don't ignore nfs_mount_options in vdsm.conf

danken at redhat.com danken at redhat.com
Tue Jun 26 20:27:23 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Don't ignore nfs_mount_options in vdsm.conf
......................................................................


Patch Set 2: I would prefer that you didn't submit this

having the static config file option override run-time, server-specific (though not host-specific) option is a very peculiar semantics.

Do you really want this behavior?
Why is this patch needed? to override timeout, retrans, and version passed by Engine? or to add more exotic options?

I'm not nacking it, just trying to understand the use case. 

Maybe you would like to add/override mount options specifically.

--
To view, visit http://gerrit.ovirt.org/5368
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list