Change in vdsm[master]: add configure variable vdsmcoredumpdir for /var/log/core

danken at redhat.com danken at redhat.com
Sun Jun 24 09:07:28 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: add configure variable vdsmcoredumpdir for /var/log/core
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 32: CORE_DUMP_PATH=@VDSMCOREDUMPDIR@/core.%p.%t.dump
I do not understand your question.

you have many patches in this branch, and I am not yet convinced about many of them. Please make this patch self-contained. You define a macro - great. Now use it all over the place (unless you have a good reason not to).

--
To view, visit http://gerrit.ovirt.org/5150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94ac220078f8a00fbdd8aba6125bedda44a77d15
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list