Change in vdsm[master]: virtEnabledInCpuAndBios: return status/proper msg

danken at redhat.com danken at redhat.com
Fri Jun 22 07:02:53 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: virtEnabledInCpuAndBios: return status/proper msg
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1303: def virtEnabledInCpuAndBios():
actually, this whole function was born in sin. a function should have one function. not two. Having two functions:

 virtEnabledInCpu()
 virtEnabledInBios()

would have been better.

--
To view, visit http://gerrit.ovirt.org/3549
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3baff7594ad2cfcf4844a30586a2e4a4313a1972
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>


More information about the vdsm-patches mailing list