Change in vdsm[master]: virtEnabledInCpuAndBios: return status/proper msg

danken at redhat.com danken at redhat.com
Wed Jun 20 19:29:48 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: virtEnabledInCpuAndBios: return status/proper msg
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

minor comments

....................................................
File vdsm_reg/deployUtil.py.in
Line 1364:         retCPU = bios_en and has_cpu
retCPU is a very odd name for a variable (not that I understand why you need a variable here)

Line 1369:         return False, "Exception"
"Exception" is not very useful give at least str(e) or the whole traceback.format_exc().

--
To view, visit http://gerrit.ovirt.org/3549
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3baff7594ad2cfcf4844a30586a2e4a4313a1972
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>


More information about the vdsm-patches mailing list