Change in vdsm[master]: MOM Integration

danken at redhat.com danken at redhat.com
Wed Jun 20 02:42:44 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: MOM Integration
......................................................................


Patch Set 10: I would prefer that you didn't submit this

(4 inline comments)

....................................................
File vdsm/constants.py.in
Line 165: #
is this really needed to be exposed in the global constants.py? I'd rather hide it in ksm.py.

....................................................
File vdsm/vdsmMOM.py
Line 22: from vdsm.config import config
due to the filename change it is a bit hard to check if all my questions were answered.

at least one, has not - this module should not have direct access to vdsm.config.config. VdsmMOM can take momconf as an arg.

that's better for testability and good relations with Saggi.

Line 30: class VdsmMOM(threading.Thread):
I do not have good suggestions, but I'm not happy with the name. We all know it is a part of the vdsm project, so the Vdsm prefix does not really help.

Line 32:     def __init__(self, log):
I think the signature would be prettier if "log" is dropped, and replaced with a logging.getLogger() call.

--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list