Change in vdsm[master]: BZ#833119 - Allow to create VLANed network on top of existin...

danken at redhat.com danken at redhat.com
Tue Jun 19 14:52:16 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#833119 - Allow to create VLANed network on top of existing bond
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 495:         bondingOptions, bridged=True):
as long as the old addNetwork api is calling this function, you shouldn't make such a change here.

you may split this "if" to a new function that will be called only by the old addNetowork flow.

--
To view, visit http://gerrit.ovirt.org/5456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If45aed68847f5a79380c629a70290a2c687cbd30
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list