Change in vdsm[master]: BZ#826873 - Allow to change bond without network attached to...

danken at redhat.com danken at redhat.com
Tue Jun 19 11:47:20 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#826873 - Allow to change bond without network attached to it
......................................................................


Patch Set 5: (1 inline comment)

Mark, no problems - it is fine to NACK after a patch is approved. I cannot notice everything and a value your opinion.

In this case I'm afraid we would have not to follow your suggestion - it's a wider change than we can chew right now.

....................................................
File vdsm/configNetwork.py
Line 985:         ifup(bond)
the down side of your suggestion is that it is harder to be sure that you are doing *everything* that initscripts does, which may lead to surprises on next boot.

The whole net configuration does this ifdown/ifup dance. I would like it to be overhauled after a close look - I don't think a local change is prudent.

--
To view, visit http://gerrit.ovirt.org/5312
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3770017d8e633ccf5f9cf9b41a93df57229c443e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list