Change in vdsm[master]: VM.create: Normalize propagateErrors semantics

danken at redhat.com danken at redhat.com
Mon Jun 18 15:05:18 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: VM.create: Normalize propagateErrors semantics
......................................................................


VM.create: Normalize propagateErrors semantics

Changes since V1:
 - Use utils.tobool() as suggested by danken

Regretably, someone chose to use the strings 'on' and 'off' instead of the
more correct True and False boolean values.  ovirt-engine compatibility
requires us to continue supporting this bad form, but we should also accept
True and False.

Change-Id: I531406b04046549b6058e2180eddbaeec8eafbce
Signed-off-by: Adam Litke <agl at us.ibm.com>
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Adam Litke: Verified
  Bing Bu Cao: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5299
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I531406b04046549b6058e2180eddbaeec8eafbce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list