Change in vdsm[master]: Properly parse configurations in function "do_create" in vds...

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Mon Jun 18 12:57:50 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Properly parse configurations in function "do_create" in vdsClient
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File tests/vdsClientTests.py
Line 53:         sys.path.remove("../vdsm_cli")
Please explain why you need to hack the path here. Is there a reason you can't do this with the other path hacks in TestCaseBase?

Line 85:         allargs[len(allargs) - 1] = 'cpuPinning={0:1,1:0}'
Why not allargs[-1]?

....................................................
File vdsm_cli/vdsClient.py
Line 161:         for line in confLines:
I'm not a fan of continue. I think you can move the cdrom/floppy to the else and make custom_ an elif.

--
To view, visit http://gerrit.ovirt.org/5093
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cd6801a6d4de3f51fc7d1e0f744bcb2c71d422f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list