Change in vdsm[master]: Internal volumes must be RW in domain version 3

fsimonce at redhat.com fsimonce at redhat.com
Mon Jun 18 09:46:56 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Internal volumes must be RW in domain version 3
......................................................................


Patch Set 13: (1 inline comment)

....................................................
File vdsm/storage/volume.py
Line 464:     def _legacySetRW(self, rwMode):
To avoid another review cycle can you suggest a name for the method? Removing the _legacy prefix makes it _setRW which is too much generic (we already have several setrw methods). I was thinking of _setTypeRW (since it has to do with the volume type). Please add as many detail as you can to avoid another iteration.

--
To view, visit http://gerrit.ovirt.org/2786
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list