Change in vdsm[master]: vdsmd: Don't keep the temporary file generated by configurin...

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon Jun 18 02:51:59 UTC 2012


Mark Wu has posted comments on this change.

Change subject: vdsmd: Don't keep the temporary file generated by configuring libvirt
......................................................................


Patch Set 1:

I have filed a sed bug and cc'ed to you :)

I think it's better to use augtool to manipulate libvirt configuration than sed.  augtool should be able to cover the use case of configuring on install and removing configuration by vdsm on uninstall. What's your opinion bout it? If you think it's good, I will submit a patch later. Thanks

--
To view, visit http://gerrit.ovirt.org/4864
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5c0fe8b86c4fa82bb89d581f594b0dfb9aae425
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list