Change in vdsm[master]: vdsmd: Don't keep the temporary file generated by configurin...

danken at redhat.com danken at redhat.com
Sun Jun 17 15:13:00 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsmd: Don't keep the temporary file generated by configuring libvirt
......................................................................


Patch Set 1:

yes, if the edited file is bind-mounted as in ovirt-node, it cannot be renamed. What you describe is a bug in sed - there is no point in sed leaving behind empty temporary files.

I'd appreciate if you open a BZ on sed. If the BZ is not fixed quickly, we can take a workaround into vdsm, and revert it later.

--
To view, visit http://gerrit.ovirt.org/4864
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5c0fe8b86c4fa82bb89d581f594b0dfb9aae425
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list