Change in vdsm[master]: tests: add netinfo test for intToAddress() function

danken at redhat.com danken at redhat.com
Thu Jun 14 16:01:15 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: tests: add netinfo test for intToAddress() function
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
File tests/netinfoTests.py
Line 54:         num = [0, 1, 16777344, 16777408, 4294967295]
I think that a dictionary would be clearer than two lists, but it's fine, too.

--
To view, visit http://gerrit.ovirt.org/5339
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I865311cb0bac338a05513b7946c11326be5047af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list