Change in vdsm[master]: SUDO change, move fuser call to super vdsm

danken at redhat.com danken at redhat.com
Wed Jun 13 18:45:58 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: SUDO change, move fuser call to super vdsm
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/fuser.py
Line 18: # Refer to the README and COPYING files for full details of the license
since this file has been written, we've grown older and smarter.

we should have a python encapsulation of fuser command line, see mount.py or gluster/cli.py for examples.

Then, you should expose some of that functionality from supervdsm.

....................................................
File vdsm/supervdsmServer.py
Line 272:     def fuser(self, path, mountPoint):
for security, you should verify that path is something that is supposed to be vdsm-controlled.

--
To view, visit http://gerrit.ovirt.org/5314
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list