Change in vdsm[master]: API: Add formal definition for disk types

danken at redhat.com danken at redhat.com
Wed Jun 13 18:21:24 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: API: Add formal definition for disk types
......................................................................


Patch Set 3: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/storage/fileVolume.py
Line 121:             'diskType' - enum (API.Image.DiskTypes)
I suppose we should be bold and move to sphinx-style documentation everywhere...

--
To view, visit http://gerrit.ovirt.org/4957
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I797bc9dd2b86678c14ba4c5abdc4a87f618b6b09
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list