Change in vdsm[master]: Add the hasHostId method to the cluster locks
mlipchuk at redhat.com
mlipchuk at redhat.com
Wed Jun 13 15:19:46 UTC 2012
Maor Lipchuk has posted comments on this change.
Change subject: Add the hasHostId method to the cluster locks
......................................................................
Patch Set 13: (1 inline comment)
Looks good to me, see comment inline
....................................................
File vdsm/storage/safelease.py
Line 191: "status, returning False", exc_info=True)
I don't see reference to argument in the log, so why use the exc_info=True for?
--
To view, visit http://gerrit.ovirt.org/3927
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list